[HTTP/2] Forward innerException's HttpRequestError to retryable HttpRequestException #89963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsIf we are doing a retry because of a protocol error, or some other (Sort-of) contributes to #89097.
|
MihaZupan
approved these changes
Aug 3, 2023
|
The CI failures are unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are doing a retry because of a protocol error, or some other
HttpIOException, we should forward the error code to the retryableHttpRequestExceptionin case it surfaces to the user. With this, surfacingHttpRequestError.Unknownshould be very rare in HTTP/2, most likely indicating a bug.(Sort-of) contributes to #89097.