Move Microsoft.NET.WebAssembly.WebCil into tasks #89999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #89987 Repo task projects need to reside under src/tasks as the TasksConfiguration property applies to these projects. By having a referenced task project outside of src/tasks, it's easy to get binclashes because of a project being built for different configurations (Debug vs Release).
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsFixes #89987 Repo task projects need to reside under src/tasks as the TasksConfiguration property applies to these projects. By having a referenced task project outside of src/tasks, it's easy to get binclashes because of a project being built for different configurations (Debug vs Release).
|
akoeplinger
approved these changes
Aug 4, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89987
Repo task projects need to reside under src/tasks as the TasksConfiguration property applies to these projects. By having a referenced task project outside of src/tasks, it's easy to get binclashes because of a project being built for different configurations (Debug vs Release).
Alternatively I could have also annotated the cross subset references to WebCil with
Configuration=$(TasksConfiguration)but the current separation of src/libraries and src/tasks is important.src/librariesshould only consist of shared framework components, out-of-band components and tests.