Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/roslyn #90255

Merged
merged 52 commits into from
Aug 21, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 9, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 037eb78c-9902-4cb9-856d-08db8ed7cafd
  • Build: 20230819.1
  • Date Produced: August 19, 2023 3:42:20 PM UTC
  • Commit: 5fcefbef4fa8a28c2ac73c8c03ab37fca30e4570
  • Branch: refs/heads/main

…809.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23409.1
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Aug 9, 2023
dotnet-maestro bot added 15 commits August 9, 2023 18:43
…809.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23409.4
…809.12

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23409.12
…809.13

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23409.13
…809.14

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23409.14
…809.15

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23409.15
…809.16

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23409.16
…809.17

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23409.17
…810.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23410.4
…810.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23410.5
…810.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23410.6
…810.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23410.8
…810.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23410.9
…810.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23410.10
…810.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23410.11
…810.12

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23410.12
…811.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23411.1
…811.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23411.3
…811.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23411.4
…811.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23411.5
…812.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23412.1
@ghost
Copy link

ghost commented Aug 12, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 037eb78c-9902-4cb9-856d-08db8ed7cafd
  • Build: 20230812.1
  • Date Produced: August 12, 2023 3:35:34 PM UTC
  • Commit: 3793c732f895cca7d98d44e85b38c241e309e425
  • Branch: refs/heads/main
Author: dotnet-maestro[bot]
Assignees: -
Labels:

area-System.Runtime.InteropServices, area-codeflow

Milestone: -

@lewing lewing closed this Aug 13, 2023
@lewing lewing reopened this Aug 13, 2023
…815.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23415.8
@jkoritzinsky
Copy link
Member

The LibraryImportGenerator.Unit.Tests failures look like the following stack:

ibraryImportGenerator.UnitTests.ConvertToLibraryImportFixerTests.SuffixAPresent_ExactSpelling_False_AutoCharSet_Provides_No_Suffix_And_Both_Suffix_Fixes [FAIL]
      System.ArgumentException : Delegate to an instance method cannot have null 'this'.
      Stack Trace:
        /_/src/coreclr/System.Private.CoreLib/src/System/MulticastDelegate.cs(571,0): at System.MulticastDelegate.ThrowNullThisInDelegateToInstance()
        /_/src/coreclr/System.Private.CoreLib/src/System/MulticastDelegate.cs(579,0): at System.MulticastDelegate.CtorClosed(Object target, IntPtr methodPtr)
        /_/src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/ConvertToLibraryImportFixer.cs(98,0): at Microsoft.Interop.Analyzers.ConvertToLibraryImportFixer.CreateAllFixesForDiagnosticOptions(SyntaxNode node, ImmutableDictionary`2 options)+MoveNext()

The function that is failing in the generator is just using regular lambda expressions in a yield return function. This is either a Roslyn bug (with generating invalid IL for lambdas) or a JIT bug exposed by changed codegen (generating the wrong call to the MulticastDelegate constructor).

…815.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23415.9
…815.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23415.10
…815.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23415.11
…815.12

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23415.12
…815.13

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23415.13
…816.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23416.2
…816.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23416.3
…816.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23416.4
…816.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23416.10
…817.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23417.1
…817.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23417.2
…817.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23417.3
…817.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23417.4
…818.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23418.2
…818.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23418.3
…818.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23418.4
@lewing
Copy link
Member

lewing commented Aug 18, 2023

cc @jaredpar

…818.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23418.5
…818.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23418.6
…819.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23419.1
@lewing lewing merged commit 78f4217 into main Aug 21, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-bcb34ee9-27b3-4270-aff6-efaed448dbd5 branch August 21, 2023 16:21
@ghost ghost locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants