Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all use of <Nullable>annotations</Nullable> #90401

Merged
merged 4 commits into from
Aug 12, 2023
Merged

Remove all use of <Nullable>annotations</Nullable> #90401

merged 4 commits into from
Aug 12, 2023

Commits on Aug 11, 2023

  1. Remove all use of <Nullable>annotations</Nullable> 

    We've inadvertently shipped multiple libraries with incorrect nullable reference type annotations because:
a) Their ref assemblies aren't actually being shipped, and/or
b) Their src projects using `<Nullable>annotations</Nullable>`

`<Nullable>annotations</Nullable>` means "I'm nullable annotated but don't validate them", which means consumers of these libraries see annotations that we haven't thoughtfully added or reviewed.

This removes all use of it and gets us back to a place where we're only shipping nullable annotations for libraries where we've done the work to ensure they're correct.  We can subsequently finish annotating these stragglers.
    @stephentoub
    stephentoub committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    cff2ecd View commit details
    Browse the repository at this point in the history

  2. Don't disable LibraryImportGenerator when nullable is disabled

    @ericstj
    ericstj committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1662e84 View commit details
    Browse the repository at this point in the history

  3. Add #nullable enable to LibraryImportAttribute file for polyfill scen… 

    …arios.
    @jkoritzinsky
    jkoritzinsky committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    bf2a90e View commit details
    Browse the repository at this point in the history

  4. Disable LibraryImportGenerator on ILCompiler.TypeSystem.Tests assembl… 

    …ies.

Convert a DllImport in HostWriter that now gets the polyfill experience.
    @jkoritzinsky
    jkoritzinsky committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f81be63 View commit details
    Browse the repository at this point in the history