Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate System.Linq.Expressions with RequiresDynamicCode #90456

Merged
merged 11 commits into from
Aug 15, 2023
Merged

Annotate System.Linq.Expressions with RequiresDynamicCode #90456

merged 11 commits into from
Aug 15, 2023

Commits on Aug 12, 2023

  1. Annotate System.Linq.Expressions with RequiresDynamicCode 

    All this ended up with an RUC on Expression.Compile due to new arrays.
I could potentially silence this warning with a feature flag, but it is a
real risk, and one that users could maybe work around if alterted to the problem.
    @agocke
    agocke committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    e0d78a5 View commit details
    Browse the repository at this point in the history

  2. Remove suppression that's no longer needed

    @agocke
    agocke committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    6a30042 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2023

  1. Fix tests for new feature switch behavior

    @agocke
    agocke committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    59ff85a View commit details
    Browse the repository at this point in the history

  2. Update src/libraries/System.Linq.Expressions/src/System/Linq/Expressi… 

    …ons/Expression.cs

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
    @agocke @eerhardt
    agocke and eerhardt authored Aug 13, 2023
    Configuration menu
    Copy the full SHA
    1622e5f View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Typo in Throws call

    @agocke
    agocke committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    fc42719 View commit details
    Browse the repository at this point in the history

  2. Fix assert for net framework

    @agocke
    agocke committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    a02ae20 View commit details
    Browse the repository at this point in the history

  3. Respond to PR comments

    @agocke
    agocke committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    4a9c305 View commit details
    Browse the repository at this point in the history

  4. Add suppression

    @agocke
    agocke committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    21819f4 View commit details
    Browse the repository at this point in the history

  5. Typo

    @agocke
    agocke committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    cd372e2 View commit details
    Browse the repository at this point in the history

  6. Update src/libraries/System.Linq.Expressions/src/Resources/Strings.resx 

    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    @agocke @stephentoub
    agocke and stephentoub authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    ed9c7c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. PR feedback

    @agocke
    agocke committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    635aa09 View commit details
    Browse the repository at this point in the history