Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workloads] Put quotes around GetFileName call when collecting telemetry #90588

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

steveisok
Copy link
Member

There are cases where %(ReferencePath) is empty, so prevent exceptions by quoting the value.

Fixes #90584

There are cases where `%(ReferencePath)` is empty, so prevent exceptions by quoting the value.

Fixes dotnet#90584
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 15, 2023
@ghost ghost assigned steveisok Aug 15, 2023
@steveisok
Copy link
Member Author

/backport to release/8.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5869125444

@steveisok steveisok merged commit 9b9fdd0 into dotnet:main Aug 16, 2023
21 checks passed
@steveisok steveisok deleted the fix-wl-tel branch August 16, 2023 11:43
@ghost ghost locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Build-mono needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry target fails in rc1
4 participants