Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Add doc for the new invoker classes #90636

Merged
merged 5 commits into from
Aug 16, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 15, 2023

Backport of #90536 to release/8.0

/cc @steveharter

Customer Impact

New doc for new v8 feature.

Testing

NA

Risk

NA

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Aug 15, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90536 to release/8.0

/cc @steveharter

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Reflection

Milestone: -

@carlossanlop
Copy link
Member

@steveharter this PR is targeting release/8.0, which is RC2. Was that your intention?

If not, then please retarget this PR to release/8.0-rc1. Once you merge this, the bot will automatically send it to release/8.0 for you.

@buyaa-n
Copy link
Contributor

buyaa-n commented Aug 16, 2023

this PR is targeting release/8.0, which is RC2. Was that your intention?

Yes, it is for RC2

@buyaa-n buyaa-n requested a review from ericstj August 16, 2023 00:00
@buyaa-n buyaa-n added the Servicing-consider Issue for next servicing release review label Aug 16, 2023
@carlossanlop
Copy link
Member

@buyaa-n let me know when the CI is done in the latest re-run. Don't press the "Update branch" button, or the CI will restart. If you ping me, I can bypass the restriction and merge the PR for you (if it's ready to merge).

@carlossanlop
Copy link
Member

Oh I see, this PR is all documentation. Can you please also port these docs to dotnet-api-docs using the PortToDocs.exe tool from dotnet/api-docs-sync ? This needs to be done before the RC2 snap so that we include it in GA.

@steveharter steveharter self-assigned this Aug 16, 2023
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 16, 2023
@carlossanlop carlossanlop merged commit 1a13ecb into release/8.0 Aug 16, 2023
@carlossanlop carlossanlop deleted the backport/pr-90536-to-release/8.0 branch August 16, 2023 20:24
@steveharter
Copy link
Member

Doc port: dotnet/dotnet-api-docs#9194

@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Reflection Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants