[release/8.0-rc1] Add missing type forwards #90673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Fixes #90578 IDispatchImplAttribute, IDispatchImplType and SetWin32ContextInIDispatchAttribute were removed with 9f1dd1a and 26a91ad Those dropped types weren't flagged because APICompat only validates reference assemblies. We have three implementation only shim assemblies: mscorlib, System and System.Data. I verified that no other type forwards were lost between .NET 7 and .NET 8.
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #90669 to release/8.0-rc1 /cc @ViktorHofer Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
carlossanlop
approved these changes
Aug 16, 2023
carlossanlop
added
Servicing-approved
|
Approved by Tactics via email. Assuming all feedback in the |
carlossanlop
added
Servicing-approved
|
Ready to merge in for .NET 8 to fix the regression. Further discussions in the main PR shouldn't affect this backport. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #90669 to release/8.0-rc1
/cc @ViktorHofer
Customer Impact
Customers migrating from .NET Framework to .NET who reference the
AssemblyRegistrationFlags,ExporterEventKind,PEFileKinds,RegistrationClassContextorRegistrationConnectionTypetypes would see an application crash because of aTypeLoadException. Reason is that type forwards are missing from the mscorlib facade assembly.Testing
Manually tested by diffing the produced assembly via ILDasm.
Risk
Low. Type forwards are added to the mscorlib.dll assembly only. Other code isn't impacted.