[release/8.0] [HTTP/3] Release the stream once the response is sent #90722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #90659 to release/8.0 /cc @ManickaP Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
karelz
approved these changes
Aug 17, 2023
|
I approve the change for release/8.0 - it will reduce test result noise from Outerloop. |
|
CI failure was just a System.Runtime test run that suddenly died. Unrelated. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #90659 to release/8.0
Fixes #90603
The offending TelemetryTest is using stream limit of 1, to unblock that limit, previous stream must be properly closed and disposed. This change makes sure that the loopback H/3 connection (used by our HTTP tests to simulate the server side) disposes the currently processed and finished request and by that the underlying stream.
/cc @ManickaP
Customer Impact
Test-only change in Outerloop test. Bug in test code uncovered by #90228.
PR #90228 changed behavior and made the test fail (21x in 2 days).
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.