-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automated] Merge branch 'release/8.0-rc1' => 'release/8.0' #90749
[automated] Merge branch 'release/8.0-rc1' => 'release/8.0' #90749
Conversation
… source build (dotnet#90714) Co-authored-by: Elinor Fung <elfung@microsoft.com>
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsI detected changes in the release/8.0-rc1 branch which have not been merged yet to release/8.0. I'm a robot and am configured to help you automatically keep release/8.0 up to date, so I've opened this PR. This PR merges commits made on release/8.0-rc1 by the following committers:
Instructions for merging from UIThis PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit. If this repo does not allow creating merge commits from the GitHub UI, use command line instructions. Instructions for merging via command lineRun these commands to merge this pull request from the command line. git fetch
git checkout release/8.0-rc1
git pull --ff-only
git checkout release/8.0
git pull --ff-only
git merge --no-ff release/8.0-rc1
# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet-maestro-bot/runtime HEAD:merge/release/8.0-rc1-to-release/8.0 or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflictsInstructions for updating this pull requestContributors to this repo have permission update this pull request by pushing to the branch 'merge/release/8.0-rc1-to-release/8.0'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
or if you are using SSH
Contact .NET Core Engineering if you have questions or issues.
|
…otnet#90748) .. because `dotnet-install --channel 8.0` is returning 9.0-alpha sdks right now. Co-authored-by: Ankit Jain <radical@gmail.com>
…in config binder gen (dotnet#90746) * Improve filtering of candidate binding invocations in config binder gen * Address feedback * Address feedback: rename helper; further tighten constraint * Add follow-up TODO * Revert TypeSyntax clause to fix failing tests --------- Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
…0049)" (dotnet#90696) This reverts commit eacb32e. Need to investigate changes because they caused a test failure.
@ericstj I'm not following. The validation badges (GitHub status checks) are based on the source-sha of the input PR branch. |
Right, and the bot created that PR branch. Since it created it as just a point in the history of the RC1 branch there were existing builds that satisfied the badges. As a result this PR didn't get any testing as a merge into 8.0. It should be creating the branch with an actual merge into the target branch so that it won't reuse rolling build results. |
I detected changes in the release/8.0-rc1 branch which have not been merged yet to release/8.0. I'm a robot and am configured to help you automatically keep release/8.0 up to date, so I've opened this PR.
This PR merges commits made on release/8.0-rc1 by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/8.0-rc1-to-release/8.0'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
or if you are using SSH
Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.