Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config names for CallCountThreshold and CallCountingDelayMs #90799

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Aug 18, 2023

I was preparing a PR to dotnet/sdk to surface these and noticed that these names are inconsistent with other tiered compilation settings, namely, https://github.com/dotnet/sdk/blob/62d3e897cce38a3df8d0ff4eb489a3f2e16f6dce/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets#L604-L611. Turns out we already have System.Runtime.TieredCompilation.* and we don't use TC_ for it.

PTAL @mangod9

@EgorBo EgorBo merged commit 2efa42b into dotnet:main Aug 19, 2023
@EgorBo
Copy link
Member Author

EgorBo commented Aug 19, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5910325322

@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants