[release/8.0-rc1] [mini] Fix typo in mono_decompose_vtype_opts #90832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Without this, if some previous instruction already created a vreg for ins->dest (for example if we are doing multiple passes over the basic block because `restart == TRUE`) we will use an incorrect vreg when decomposing the current VMOVE Fixes #90800
This is used by a CreateSpan optimization that needs access to the MonoClassField* For other cases of a bare LDTOKEN (such as hand-written IL that calls LDTOKEN on a type but doesn't follow it up with a call to `GetTypeFromHandle` leave the opcode as a VMOVE (from the `EMIT_NEW_TEMPLOAD` above))
github-actions
bot
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
|
We already started the builds for RC1. Please fill out the template, send an email to Tactics requesting approval, get a code review sign off, and please let me know when the CI finishes so I can ask if we can still merge. |
lewing
approved these changes
Aug 18, 2023
lewing
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #90825 to release/8.0-rc1
/cc @lambdageek
Customer Impact
Customers are not able to use the new (opt-in) managed static registrar on .NET for iOS.
The registrar relies on an IL code generator to create some new managed methods that use an IL pattern that is different from what Roslyn normally generates. As a result, the IL has uncovered a bug in Mono's code generator. As a result certain equality comparisons between
RuntimeTypeHandlevalues are compiled incorrectly and give incorrect results. The impact is that the new managed static registrar creates apps that do not work.Testing
Manual testing.
Risk
Low/Medium. The code generator fix may have impact on other scenarios that use the Mono JIT or AOT compiler (Android, WASM). However, if this fix itself introduces a new codegen bug, it can be reverted, and .NET for iOS can fall back to the old registrar, or they can try to alter the IL pattern that their custom tool generates.