Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] [mono][interp] Mask all shift amounts #90991

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 23, 2023

Backport of #90666 to release/8.0

/cc @BrzVlad

Customer Impact

In C#, the shift operator implies a masking of the shift amount according to the operand width. The vectorized intrinsics computing shifts added on interpreter for this release regressed this behavior. Prior to this fix, using Vector128 Shift intrinsics with shift amount over the operand bit width was producing incorrect values.

Testing

Tested locally. Regression discovered with tests from our suite, which are now passing.

Risk

Very low.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Aug 23, 2023

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90666 to release/8.0

/cc @BrzVlad

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Codegen-Interpreter-mono

Milestone: -

@fanyang-mono fanyang-mono added the Servicing-consider Issue for next servicing release review label Aug 23, 2023
@fanyang-mono fanyang-mono added this to the 8.0.0 milestone Aug 23, 2023
@SamMonoRT
Copy link
Member

@marek-safar @jeffschwMSFT - release\8.0 approval needed for this PR

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. once ready you can merge

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 23, 2023
@carlossanlop
Copy link
Member

@BrzVlad @fanyang-mono @SamMonoRT The CI has mono faiures, are they related?

Note: Please ping me when ready. I can merge it for you to bypass the merge restriction, so no need to click on "Update branch", or it will restart the CI (only click it if you really really need to rebase on top of the base branch).

@carlossanlop carlossanlop merged commit 09e3266 into release/8.0 Aug 23, 2023
159 of 162 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90666-to-release/8.0 branch August 23, 2023 23:03
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants