[NOT READY] GC: Rearrange finalization queue to put freelist in middle #91029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding clrgc variant with regions enabled * only build regions for 64 bit platforms * rename to clrgcexp for experimental
|
Tagging subscribers to this area: @dotnet/gc Issue Detailsnull
|
This was referenced Aug 24, 2023
markples
commented
Aug 25, 2023
markples
commented
Aug 25, 2023
markples
commented
Aug 25, 2023
markples
commented
Aug 28, 2023
markples
added a commit
that referenced
this pull request
Sep 8, 2023
Pulled from #91029 - Add `FinalizerStartSeg`, `FinalizerMaxSeg`, and `MaxSeg` to make some of the code resilient to changes in the layout of the finalization queue. Also make `WalkFReachableObjects` resilient to layout changes. - Add `FreeListSeg` as redundant entry for `FreeList` - The free list section is a segment; it just has its boundary stored differently. In #91029 it will be moved to the middle of the queue. - This provides a convenient audit point for all references to `FreeList` for #91029. The ones that are renamed here should be independent of the queue layout. - #91029 will remove `FreeList` when the other uses are updated. - Add case for `SegQueueLimit` of last segment. Add helper `UsedCount`. - Fix `GetNumberFinalizableObjects` to include critical finalizers, though this method isn't called anywhere today. - Add `const int INITIAL_FINALIZER_ARRAY_SIZE = 100;`
markples
force-pushed
the
finalize-segments
branch
from
a801c4f to
2dd26dd
Compare
markples
force-pushed
the
finalize-segments
branch
from
79bdf90 to
9e27770
Compare
markples
force-pushed
the
finalize-segments
branch
from
9e27770 to
58ac965
Compare
markples
force-pushed
the
finalize-segments
branch
from
6a125a4 to
7d83dea
Compare
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo:
Partially regains loss in #87826