Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoongArch64] Fix the compile error after #88034. #91109

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[LoongArch64] Fix the compile error after #88034. #91109

merged 1 commit into from
Aug 25, 2023

Conversation

LuckyXu-HF
Copy link
Contributor

This PR is part of the issue #69705 to amend the LA's port.

Fix the compile error for LoongArch64 after #88034.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 25, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 25, 2023
@LuckyXu-HF
Copy link
Contributor Author

cc @shushanhf ,Could you please review this PR?
Thanks

shushanhf
shushanhf approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@shushanhf shushanhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@am11 am11 requested a review from janvorli August 25, 2023 09:04
@janvorli janvorli added area-ExceptionHandling-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 25, 2023
janvorli
janvorli approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit 71c68bf into dotnet:main Aug 25, 2023
@LuckyXu-HF LuckyXu-HF deleted the main-LA64A branch August 28, 2023 02:41
@ghost ghost locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shushanhf shushanhf shushanhf approved these changes

@janvorli janvorli janvorli approved these changes

Assignees
No one assigned
Labels
arch-loongarch64 area-ExceptionHandling-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuckyXu-HF @janvorli @shushanhf