-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable consumption of PGO data #91297
Conversation
Tagging subscribers to this area: @hoyosjs |
db31380
to
3aa7311
Compare
Sorry, this didn't get updated. We have had updated PGO data for the last three weeks. |
now that runtime official build has over come an infra issue, this issue is now the top cause of build breaks. what is the ETA for getting it merged? |
3aa7311
to
55f5340
Compare
I think #91497 might need to be merged first. I'll cherry pick the changes from that PR into this one to see if that is the case. |
@jeffschwMSFT what build breaks is this causing? #89311 went in last week (29-AUG) and we've had successful builds since then. |
If you are talking about the |
It looks like #91497 does not currently contain the updated linker flags that would allow this PR to be merged. |
55f5340
to
e84c40f
Compare
8fe1378
to
920646b
Compare
920646b
to
9aa92c6
Compare
9aa92c6
to
5d3bbfc
Compare
5d3bbfc
to
0af29c6
Compare
Is this ready to merge? |
@DrewScoggins It can be merged once the main branch contains PGO data that was produced from the main branch. Currently it appears the PGO data is being built from the 8.0 branch, which is not compatible. See #93280 for an example of PR that updates the PGO data. |
0af29c6
to
d05fcea
Compare
d05fcea
to
a248141
Compare
This reverts commit 810231c.
a248141
to
e7d26c5
Compare
Hi all, #95510 was recently merged. Is this PR ready to be merged? |
I can be merged once the CI is green. |
It is still failing with this error:
I'm guessing the PGO data is being built from the dotnet/runtime 8.0 branch, which does not have the |
Closing in favor of #95540 . |
This reverts commit 810231c from #89311. Once the PGO data has been updated with the new linker flags and CI passes on this PR, this can be merged to reenable PGO.