Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Add link to docs to interop error messages #91328

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented Aug 30, 2023

Previous

error SYSLIB1072: The type 'Task<int[]>' is not supported by source-generated JavaScript interop. The generated source will not handle marshalling of parameter 'meaning'.

New

error SYSLIB1072: The type 'Task<int[]>' is not supported by source-generated JavaScript interop. The generated source will not handle marshalling of parameter 'meaning'. For more information see https://aka.ms/dotnet-wasm-jsinterop

@maraf maraf added this to the 9.0.0 milestone Aug 30, 2023
@maraf maraf self-assigned this Aug 30, 2023
@ghost
Copy link

ghost commented Aug 30, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Previous

error SYSLIB1072: The type 'Task<int[]>' is not supported by source-generated JavaScript interop. The generated source will not handle marshalling of parameter 'meaning'.

New

error SYSLIB1072: The type 'Task<int[]>' is not supported by source-generated JavaScript interop. The generated source will not handle marshalling of parameter 'meaning'. For more information see https://aka.ms/dotnet-wasm-jsinterop
Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: 9.0.0

@maraf
Copy link
Member Author

maraf commented Aug 31, 2023

Failures are unrelated.

@maraf maraf merged commit 838b21f into dotnet:main Aug 31, 2023
104 of 116 checks passed
@maraf maraf deleted the WasmInteropLinkToDocs branch August 31, 2023 08:31
@maraf
Copy link
Member Author

maraf commented Aug 31, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6034955261

@campersau
Copy link
Contributor

It looks like a lot of builds are failing because of this e.g.:
https://github.com/dotnet/runtime/pull/91295/checks?check_run_id=16387189207

.packages/microsoft.dotnet.helix.sdk/8.0.0-beta.23428.2/tools/azure-pipelines/AzurePipelines.MultiQueue.targets(42,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test JSImportGenerator.Unit.Tests.Fails.ValidateFailSnippets has failed. Check the Test tab or this console log: https://helix.dot.net/api/2019-06-17/jobs/eb3774d0-182b-4f82-a236-642cd0fad4ae/workitems/JSImportGenerator.Unit.Tests/console

These messages need to be updated as well:

public static IEnumerable<object?[]> CodeSnippetsToFail()
{
yield return new object?[] { CodeSnippets.DefaultReturnMarshaler<long>(), new string[] {
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of long. The generated source will not handle marshalling of the return value of method 'Import1'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of long. The generated source will not handle marshalling of the return value of method 'Export1'.",
},null };
yield return new object?[] { CodeSnippets.DefaultReturnMarshaler<object>(), null, null };
yield return new object?[] { CodeSnippets.DefaultReturnMarshaler("System.Func<string>"), null, null };
yield return new object?[] { CodeSnippets.DefaultReturnMarshaler("System.Action"), new string[] {
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of global::System.Action. The generated source will not handle marshalling of the return value of method 'Import1'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of global::System.Action. The generated source will not handle marshalling of the return value of method 'Export1'.",
},null };
yield return new object?[] { CodeSnippets.DefaultReturnMarshaler("System.Span<byte>"), null, null };
yield return new object?[] { CodeSnippets.DefaultReturnMarshaler("System.Span<long>"), null, null };
yield return new object?[] { CodeSnippets.DefaultReturnMarshaler("System.ArraySegment<byte>"), null, null };
yield return new object?[] { CodeSnippets.AllMissing, new string[] {
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of object. The generated source will not handle marshalling of parameter 'a1'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of long. The generated source will not handle marshalling of parameter 'a2'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of long. The generated source will not handle marshalling of parameter 'a3'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of global::System.Action. The generated source will not handle marshalling of parameter 'a4'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of global::System.Func<int>. The generated source will not handle marshalling of parameter 'a5'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of global::System.Span<byte>. The generated source will not handle marshalling of parameter 'a6'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of global::System.ArraySegment<byte>. The generated source will not handle marshalling of parameter 'a7'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of global::System.Threading.Tasks.Task<object>. The generated source will not handle marshalling of parameter 'a8'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of object[]. The generated source will not handle marshalling of parameter 'a9'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of global::System.DateTime. The generated source will not handle marshalling of parameter 'a10'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of global::System.DateTimeOffset. The generated source will not handle marshalling of parameter 'a11'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of global::System.Threading.Tasks.Task<global::System.DateTime>. The generated source will not handle marshalling of parameter 'a12'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of global::System.Threading.Tasks.Task<global::System.DateTimeOffset>. The generated source will not handle marshalling of parameter 'a13'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of global::System.Threading.Tasks.Task<long>. The generated source will not handle marshalling of parameter 'a14'.",
"Please annotate the argument with 'JSMarshalAsAttribute' to specify marshaling of global::System.Threading.Tasks.Task<long>. The generated source will not handle marshalling of parameter 'a15'.",
},null };
yield return new object?[] { CodeSnippets.InOutRef, new string[] {
"Parameters with 'in', 'out' and 'ref' modifiers are not supported by source-generated JavaScript interop. The generated source will not handle marshalling of parameter 'a1'.",
"Parameters with 'in', 'out' and 'ref' modifiers are not supported by source-generated JavaScript interop. The generated source will not handle marshalling of parameter 'a2'.",
"Parameters with 'in', 'out' and 'ref' modifiers are not supported by source-generated JavaScript interop. The generated source will not handle marshalling of parameter 'a3'.",
}, null };
}

@jkotas
Copy link
Member

jkotas commented Aug 31, 2023

Failures are unrelated.

When the failures are unrelated, you are still expected to make sure that there is https://github.com/dotnet/runtime/issues?q=is%3Aissue+is%3Aopen+label%3Ablocking-clean-ci issue open that track the failures.

@maraf
Copy link
Member Author

maraf commented Aug 31, 2023

When the failures are unrelated, you are still expected to make sure that there is https://github.com/dotnet/runtime/issues?q=is%3Aissue+is%3Aopen+label%3Ablocking-clean-ci issue open that track the failures.

This was a hasty mistake. I'm sorry for that.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants