Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix impNonConstFallback #91345

Merged
merged 4 commits into from
Sep 2, 2023
Merged

Fix impNonConstFallback #91345

merged 4 commits into from
Sep 2, 2023

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Aug 30, 2023

Fixes #91335

I don't think it needs to be ported to 8.0 because non-constant values for imm-like arguments are not a production scenario (and is expected to cause compiler warrnings).

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 30, 2023
@ghost ghost assigned EgorBo Aug 30, 2023
@ghost
Copy link

ghost commented Aug 30, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #91335

I don't think it needs to be ported to 8.0 because non-constant values for imm-like arguments are not a production scenario (and is expected to cause compiler warrnings).

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@tannergooding
Copy link
Member

tannergooding commented Aug 31, 2023

I don't think it needs to be ported to 8.0 because non-constant values for imm-like arguments are not a production scenario (and is expected to cause compiler warrnings).

These can happen frequently for cases like the evaluating things in the debugger.

I think more notably there won't be any problems here because the underlying instruction expects 16-byte alignment and that's what the constant will be (and more concretely, the instructions support any alignment technically). The assert is only because it's expecting homogenous arguments and so checking for 32-byte alignment since we're expecting all constants are properly aligned (because that's good for perf).

Since there's no functional correctness (nor even a bad CQ) issue here, there's no need to backport as it will never surface to the end user.

@EgorBo EgorBo merged commit 907d094 into dotnet:main Sep 2, 2023
147 checks passed
@EgorBo EgorBo deleted the impNonConstFallback branch September 2, 2023 23:04
@ghost ghost locked as resolved and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failed '(reinterpret_cast<size_t>(addr) & (byteSize - 1)) == 0' during 'Emit code'
3 participants