Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Add late binding lookup in VB.NET for COM objects #91433

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 31, 2023

Backport of #91399 to release/8.0

/cc @AaronRobinsonMSFT

Customer Impact

Late bound look-up on COM objects fails in Visual Basic, but works using C#'s dynamic keyword - see #90541.

Testing

Validated with customer repro application. Sharing private build for further validation.

Risk

Low. This only impacts Visual Basic scenarios involving late-bound COM objects.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Aug 31, 2023

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #91399 to release/8.0

/cc @AaronRobinsonMSFT

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Microsoft.VisualBasic

Milestone: -

@AaronRobinsonMSFT AaronRobinsonMSFT added Servicing-consider Issue for next servicing release review NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Aug 31, 2023
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 8.0.0 milestone Aug 31, 2023
@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 1, 2023
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. once ready you can merge.

@carlossanlop
Copy link
Member

@AaronRobinsonMSFT would you mind filling out the template in the PR description? Just to make sure it's well documented.

@carlossanlop
Copy link
Member

Btw this is still marked as no merge. Ping me when it's ready.

@AaronRobinsonMSFT
Copy link
Member

Btw this is still marked as no merge. Ping me when it's ready.

Yep. We are waiting on customer validation before merge.

@AaronRobinsonMSFT AaronRobinsonMSFT removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 6, 2023
@AaronRobinsonMSFT
Copy link
Member

@carlossanlop We have confirmation from the customer this fix addresses their issue. I've just merged tip into this branch. Should be ready to go once green. I will ping you once I see it.

@jkotas jkotas merged commit b40f212 into release/8.0 Sep 6, 2023
101 of 106 checks passed
@jkotas jkotas deleted the backport/pr-91399-to-release/8.0 branch September 6, 2023 23:54
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants