Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Fix LDTOKEN of methods that have modifiers #91439

Merged
merged 1 commit into from
Sep 1, 2023
Merged

[release/8.0] Fix LDTOKEN of methods that have modifiers #91439

merged 1 commit into from
Sep 1, 2023

Commits on Sep 1, 2023

  1. Fix LDTOKEN of methods that have modifiers 

    When we started generating custom modifiers into metadata format to support new function pointer APIs in #85504, we should have also added it to native layout format. We currently have a mismatch. This is a low risk bugfix to ignore modifiers on the metadata side. We'll want to do a full fix to actually emit and compare this. Tracked in a .NET 9 bug at #91381.

No regression test because I spent too much time being puzzled at why https://github.com/Handlebars-Net/Handlebars.Net/blob/50614fd844e5360eb10e76154aa74da4d7bf12ce/source/Handlebars/Helpers/IHelperDescriptor.cs#L13 is generated as a custom modifier (`[in] !TOptions& modreq([netstandard]System.Runtime.InteropServices.InAttribute) options`) whereas if I do it, I get `[in] !T& 'value'` with a custom attribute. We'll want to write a proper set of tests with ambiguities for the bug I opened anyway.
    @MichalStrehovsky
    MichalStrehovsky authored and github-actions committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    b872a63 View commit details
    Browse the repository at this point in the history