[release/8.0] Update dependencies from dotnet/roslyn

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

• Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
• Build: 20230909.2
• Date Produced: September 10, 2023 5:42:35 AM UTC
• Commit: d080175cabfe297ebf079af099279b61913bcc28
• Branch: refs/heads/main

• Updates:
  • Microsoft.CodeAnalysis: from 4.8.0-3.23451.1 to 4.8.0-3.23459.2
  • Microsoft.CodeAnalysis.CSharp: from 4.8.0-3.23451.1 to 4.8.0-3.23459.2
  • Microsoft.Net.Compilers.Toolset: from 4.8.0-3.23451.1 to 4.8.0-3.23459.2

[ericstj]

I think this PR introduced failures in CI. After this was merged we're seeing failures like:

System.Tests.Types.GenericInterface1Tests.Attributes_Get_ReturnsExpected

Error message
Assert.Equal() Failure
Expected: Public | ClassSemanticsMask | Abstract
Actual:   Public | ClassSemanticsMask | Abstract | BeforeFieldInit

Stack trace
   at System.Tests.Types.TypePropertyTestBase.Attributes_Get_ReturnsExpected() + 0x7c
   at System.Runtime.Tests!<BaseAddress>+0x1614bf0
   at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0xcc

[ericstj]

@carlossanlop will back this out and we'll address the problem in #91913

[steveharter]

Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850

[ericstj]

Yes, that could be it. The roslyn build we picked up was from 9/9 and included that change.

[ericstj]

Probably we just need to change the tests if we agree with that change. We'd need to make that test change in #91913 - @steveharter or @AlekseyTs can you help with this?

[steveharter]

Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:

runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409 in 32d2bcd

public override TypeAttributes Attributes => TypeAttributes.AutoLayout | TypeAttributes.AnsiClass | TypeAttributes.Class | TypeAttributes.Public | TypeAttributes.ClassSemanticsMask | TypeAttributes.Abstract;

or just remove that LOC since the base class has the same implementation for that virtual property.

[carlossanlop]

Would this Roslyn change be in the same timeframe (5 days ago?): dotnet/roslyn#69850

Yes, this codeflow included the breaking change. I was out last week so no one was merging 8.0 PRs until I came back.

[ericstj]

Sure, I believe this one LOC needs to add TypeAttributes.BeforeFieldInit here:

runtime/src/libraries/System.Runtime/tests/System/Type/TypePropertyTests.cs

Line 409 in 32d2bcd

public override TypeAttributes Attributes => TypeAttributes.AutoLayout | TypeAttributes.AnsiClass | TypeAttributes.Class | TypeAttributes.Public | TypeAttributes.ClassSemanticsMask | TypeAttributes.Abstract;

or just remove that LOC since the base class has the same implementation for that virtual property.

@steveharter I went ahead and made that change directly in the branch. We'll see if that fixes it. We should make the same change in main's roslyn update if it does.