Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Handle mistyped commas in morph in pre-order too #91587

Merged
merged 2 commits into from
Sep 7, 2023
Merged

JIT: Handle mistyped commas in morph in pre-order too #91587

merged 2 commits into from
Sep 7, 2023

Commits on Sep 5, 2023

  1. JIT: Compensate for mistyped commas in morph pre-order too 

    Morph has post-order logic to compensate for mistyped commas produced by
impStoreStruct. However, block morphing can optimize unused stores into
INDs; this interacts with the mistyped commas to produce illegal IR
shapes (e.g. `COMMA<simd12>(..., IND<ubyte>(...))`).

The ideal solution is to fix impStoreStruct (dotnet#91586 tracks this), but
this change has a more surgical fix for the problem that can be
backported to .NET 8.

Fix dotnet#91443
    @jakobbotsch
    jakobbotsch committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    5db155a View commit details
    Browse the repository at this point in the history

  2. Fix build

    @jakobbotsch
    jakobbotsch committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    4ebeb98 View commit details
    Browse the repository at this point in the history