Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoongArch64-RISCV64] Refactor the profiler for LoongArch64 and also fix some errors for RISCV64. #91722

Merged
merged 4 commits into from
Sep 8, 2023
Merged

[LoongArch64-RISCV64] Refactor the profiler for LoongArch64 and also fix some errors for RISCV64. #91722

merged 4 commits into from
Sep 8, 2023

Conversation

shushanhf
Copy link
Contributor

This PR is part of the issue #69705 to amend the LA's port.

Refactor the profiler for LoongArch64 and also fix some errors for RISCV64 after #91595

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 7, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 7, 2023
@shushanhf shushanhf added arch-loongarch64 arch-riscv Related to the RISC-V architecture labels Sep 7, 2023
@shushanhf
Copy link
Contributor Author

@tomeksowi @clamp03
Had added for LoongArch64.
I also modify RISCV64. BTW the RISCV64 might be optimized further.

@build-analysis build-analysis bot mentioned this pull request Sep 7, 2023
Closed
tomeksowi
tomeksowi approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@tomeksowi tomeksowi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RISC-V changes look good to me, thanks for the stack alignment fix.

clamp03
clamp03 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@clamp03 clamp03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@shushanhf
Copy link
Contributor Author

If don‘t add the update the args registers within the GenerateProfileHelper， the origin patch of this PR is OK while you run the RunTest within the src/tests/profiler/unittest/inlining.cs.

The update the args registers within the GenerateProfileHelper is used to fix the error about the args within the Main(string[] args).

Now the related profiler tests is OK.

@jkotas
Could you please review this PR?
Thanks very much!

@shushanhf
add assert(!compiler->compProfilerMethHndIndirected) within the
cda96f8 
`genProfilingLeaveCallback()` and `genProfilingEnterCallback()`.
@build-analysis build-analysis bot mentioned this pull request Sep 8, 2023
Open
@ghost
Copy link

ghost commented Sep 8, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is part of the issue #69705 to amend the LA's port.

Refactor the profiler for LoongArch64 and also fix some errors for RISCV64 after #91595

Author: shushanhf
Assignees: -
Labels:

area-Diagnostics-coreclr, community-contribution, arch-loongarch64, arch-riscv, needs-area-label
Milestone: -

@jkotas jkotas requested a review from davmason September 8, 2023 16:25
@jkotas jkotas removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 8, 2023
jkotas
jkotas approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkotas jkotas merged commit 9d62c3c into dotnet:main Sep 8, 2023
120 of 127 checks passed
@shushanhf shushanhf deleted the profiler_LA branch September 11, 2023 01:06
@ghost ghost locked as resolved and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch left review comments

@tomeksowi tomeksowi tomeksowi approved these changes

@davmason davmason davmason approved these changes

@jkotas jkotas jkotas approved these changes

@clamp03 clamp03 clamp03 approved these changes

Assignees
No one assigned
Labels
arch-loongarch64 arch-riscv Related to the RISC-V architecture area-Diagnostics-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shushanhf @tomeksowi @clamp03 @jkotas @jakobbotsch @davmason