Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISC-V] ELT profiler: fix reconstruction of struct args passed partially on the stack #91797

Merged
merged 2 commits into from
Sep 8, 2023
Merged

[RISC-V] ELT profiler: fix reconstruction of struct args passed partially on the stack #91797

merged 2 commits into from
Sep 8, 2023

Conversation

tomeksowi
Copy link
Contributor

The fix is similar to what ShuffleIterator is doing, i.e. if ArgIterator returns a general register offset that can't fit argSize, this means the other part of the struct was spilled on the stack.

Part of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @alpencolt @gbalykov @clamp03 @sirntar @yurai007

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 8, 2023
@ghost
Copy link

ghost commented Sep 8, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

The fix is similar to what ShuffleIterator is doing, i.e. if ArgIterator returns a general register offset that can't fit argSize, this means the other part of the struct was spilled on the stack.

Part of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @alpencolt @gbalykov @clamp03 @sirntar @yurai007

Author: tomeksowi
Assignees: -
Labels:

area-Diagnostics-coreclr
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Sep 8, 2023
Closed
@tomeksowi
Copy link
Contributor Author

@davmason PR ready for review
+ @jkotas

davmason
davmason approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@davmason davmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Profiler test changes LGTM

@jkotas jkotas merged commit 520236d into dotnet:main Sep 8, 2023
@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Sep 9, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davmason davmason davmason approved these changes

Assignees

@tomeksowi tomeksowi

Labels
arch-riscv Related to the RISC-V architecture area-Diagnostics-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomeksowi @davmason @clamp03 @jkotas