Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Don't log warnings for certain RemoveAttributeInstances #91866

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[release/8.0] Don't log warnings for certain RemoveAttributeInstances #91866

merged 1 commit into from
Sep 12, 2023

Commits on Sep 11, 2023

  1. Don't log warnings for certain RemoveAttributeInstances 

    Fixes #88994.

ILLinker attribute XML format has a way to express "only remove these attributes when parameter X has value of Y". We currently generate a warning and don't trim the attribute at all.

The savings from trimming these attributes are going to be miniscule. Even in IL, this is scraping the bottom of the barrel. In Native AOT these attributes are pretty effectively deduplicated across assemblies. We'll likely never need this.

This keeps the existing behavior (don't trim the attribute), but removes the warning.
    @MichalStrehovsky
    MichalStrehovsky authored and github-actions committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    4450c13 View commit details
    Browse the repository at this point in the history