Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Update FixupPrecode and StubPrecode types for ARM #92075

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 14, 2023

Backport of #92030 to release/8.0

/cc @tommcdon

Customer Impact

Managed debugging on arm32 linux fails
Fixes #81921

Testing

Validation that arm32 debugging is working

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Sep 14, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92030 to release/8.0

/cc @tommcdon

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Diagnostics-coreclr, area-VM-coreclr

Milestone: -

@tommcdon tommcdon added this to the 8.0.0 milestone Sep 14, 2023
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. please get a code review. once ready this can be merged

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Sep 14, 2023
@carlossanlop
Copy link
Member

@janvorli can you please provide a code review sign-off?

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@carlossanlop carlossanlop merged commit 740081f into release/8.0 Sep 15, 2023
110 checks passed
@carlossanlop carlossanlop deleted the backport/pr-92030-to-release/8.0 branch September 15, 2023 16:36
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants