Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger] Support indexing by array schema #92337

Merged
merged 7 commits into from
Sep 26, 2023
Merged

[wasm][debugger] Support indexing by array schema #92337

merged 7 commits into from
Sep 26, 2023

Conversation

ilonatommy
Copy link
Member

Fixes partially #77536.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Sep 20, 2023
@ilonatommy ilonatommy requested a review from thaystg as a code owner September 20, 2023 11:39
@ilonatommy ilonatommy self-assigned this Sep 20, 2023
@ilonatommy ilonatommy requested a review from radical as a code owner September 20, 2023 11:39
@ilonatommy ilonatommy mentioned this pull request Sep 20, 2023
Closed
3 tasks
@ghost
Copy link

ghost commented Sep 20, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes partially #77536.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Sep 20, 2023
Closed
@ilonatommy ilonatommy requested a review from thaystg September 21, 2023 06:02
@ilonatommy
Copy link
Member Author

@thaystg, it should be the same as for object: t->type is MONO_TYPE_VALUETYPE. I updated the code, for the array test case it comes with: t->type = 0x11, type = 0x14.

This was referenced Sep 25, 2023
Closed
Open
@ilonatommy ilonatommy merged commit f276c51 into dotnet:main Sep 26, 2023
104 of 106 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thaystg thaystg thaystg approved these changes

@radical radical Awaiting requested review from radical

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilonatommy @radical @thaystg