You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm currently working on trimming for the runtime tests. It might be good to wait for this to be merged before proceeding. Assuming that the publish is done on build machine, how do you plan to invoke the trimmer?
I tried to hook it into the pipeline after the build target, which is the default one for the runtime tests, but it seems the PrepareForILLink has an indirect dependency on one of the publish targets (_ComputeAssembliesToPostprocessOnPublish).
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in conjunction with #92645. Instead of trimming on build machine, do it on helix.