Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Remove all PGO assets except for the runtime PGO archive. #92735

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 27, 2023

Backport of #92668 to release/8.0

/cc @jkoritzinsky

Customer Impact

Infrastructure-only change to not produce assets that we don't use from our PGO build legs.

We were producing assets in our PGO legs that we don't actually use (and that were overwriting each other and other legs outputs).

Testing

Local validation

Risk

Low risk.

@ghost
Copy link

ghost commented Sep 27, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92668 to release/8.0

/cc @jkoritzinsky

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@jkoritzinsky jkoritzinsky added the Servicing-consider Issue for next servicing release review label Sep 27, 2023
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. please get a code review. let's treat this as tell mode and this can be merged when ready

cc @carlossanlop

@jkoritzinsky jkoritzinsky added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 27, 2023
@jkoritzinsky jkoritzinsky force-pushed the backport/pr-92668-to-release/8.0 branch from 8a3f1d3 to effd46b Compare September 27, 2023 18:43
@jkoritzinsky jkoritzinsky changed the base branch from release/8.0 to release/8.0-rc2 September 27, 2023 18:43
@jkoritzinsky
Copy link
Member

Retargeted to RC2 as requested by @steveisok

@ericstj
Copy link
Member

ericstj commented Sep 27, 2023

Aren't we done with RC2?

@jkoritzinsky
Copy link
Member

Based on the discussion in the tactics chat, I'll retarget back to release/8.0.

@jkoritzinsky jkoritzinsky force-pushed the backport/pr-92668-to-release/8.0 branch from effd46b to 8a3f1d3 Compare September 27, 2023 18:53
@jkoritzinsky jkoritzinsky changed the base branch from release/8.0-rc2 to release/8.0 September 27, 2023 18:53
@jkoritzinsky
Copy link
Member

/azp run dotnet-linker-tests,runtime,runtime-dev-innerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@carlossanlop
Copy link
Member

@jkoritzinsky @steveisok just to confirm -

  • I see two target branch changes. Is release/8.0 the correct one?
  • Do you need me to merge without waiting for the CI to finish?

@carlossanlop
Copy link
Member

Got confirmation via chat from @steveisok . Merging now.

@carlossanlop carlossanlop merged commit 885100b into release/8.0 Sep 27, 2023
33 of 151 checks passed
@carlossanlop carlossanlop deleted the backport/pr-92668-to-release/8.0 branch September 27, 2023 19:14
@ghost ghost locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants