Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Update Ubuntu 16.04 amd64 queues to 22.04 #92794

Merged

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented Sep 28, 2023

Also use the queues with the *.svc suffix

@carlossanlop carlossanlop added this to the 6.0.x milestone Sep 28, 2023
@carlossanlop carlossanlop self-assigned this Sep 28, 2023
@ghost
Copy link

ghost commented Sep 28, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure

Milestone: 6.0.x

@carlossanlop carlossanlop changed the title [release/6.0] Update Ubuntu 16.04 queues to 22.04 [release/6.0] Update Ubuntu 16.04 adm64 queues to 22.04 Sep 28, 2023
@carlossanlop carlossanlop changed the title [release/6.0] Update Ubuntu 16.04 adm64 queues to 22.04 [release/6.0] Update Ubuntu 16.04 amd64 queues to 22.04 Sep 28, 2023
@agocke
Copy link
Member

agocke commented Sep 28, 2023

Am I reading this right that this is only the docker host container that's changing?

@carlossanlop
Copy link
Member Author

@agocke According to the email, the ask is to only bump the 1604 ones. Did I miss something?

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Sep 28, 2023
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it 😁

should have mentioned in #92796 as well: using .svc queues makes sense across the board. but @ilyas1974 probably won't get too annoyed if some are left behind.

similarly, you should be able to use ubuntu.2204.* queues everywhere you're testing in a Docker container. but we're not currently asking for everyone to stop using ubuntu.1804.*.

@carlossanlop
Copy link
Member Author

Ah! Good to know, @dougbu. I suspect that's what @agocke was going to say next. 😄

I can do that in a separate PR. For now I only wanted to address the main request.

@agocke
Copy link
Member

agocke commented Sep 28, 2023

What I was asking is: I read (Alpine.314.Amd64.Open)ubuntu.2204.amd64.open.svc@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.14-helix-amd64 as saying, "run an alpine docker image on top of an ubuntu.22.04" host OS. So, the actual code running in this test is still seeing the same Alpine image as before, and it's just a question of which OS the kick-off code sees.

Is that right?

@dougbu
Copy link
Member

dougbu commented Sep 28, 2023

Is that right?

Yes.

Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM

@carlossanlop carlossanlop merged commit f13337f into dotnet:release/6.0-staging Sep 29, 2023
142 of 147 checks passed
@carlossanlop carlossanlop deleted the UpdateUbuntu1604Queues6 branch September 29, 2023 01:19
@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants