Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Don't trigger runtime pipelines on perf pipeline only changes #92903

Merged
merged 5 commits into from
Oct 3, 2023
Merged

CI: Don't trigger runtime pipelines on perf pipeline only changes #92903

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fea043e
CI: Don't trigger runtime pipelines on perf pipeline only changes
radical Oct 2, 2023
fa964f0
Merge remote-tracking branch 'origin/main' into wasm-perf-pipeline-tr…
radical Oct 2, 2023
1b5e14f
dummy change
radical Oct 2, 2023
ae26fe5
address review feedback from @ cincuranet
radical Oct 3, 2023
efd8e1e
Merge remote-tracking branch 'origin/main' into wasm-perf-pipeline-tr…
radical Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions eng/pipelines/common/evaluate-default-paths.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@ parameters:
eng/testing/bump-chrome-version.proj
eng/testing/ChromeVersions.props
]
_perf_pipeline_specific_only: [
eng/pipelines/runtime-wasm-perf.yml
eng/pipelines/coreclr/perf*yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be perf*.yml.

eng/pipelines/coreclr/templates/perf-job.yml
cincuranet marked this conversation as resolved.
Show resolved Hide resolved
eng/pipelines/coreclr/templates/*-perf-*
eng/pipelines/coreclr/templates/run-perf*
eng/testing/performance/*
]

# src/workloads is only used in runtime-official builds
# where evaluate-paths is not used
Expand Down Expand Up @@ -90,6 +98,7 @@ jobs:
- ${{ parameters._const_paths._wasm_specific_only }}
- ${{ parameters._const_paths._wasm_pipelines }}
- ${{ parameters._const_paths._always_exclude }}
- ${{ parameters._const_paths._perf_pipeline_specific_only }}

- subset: mono_excluding_wasm
include:
Expand All @@ -101,6 +110,7 @@ jobs:
- ${{ parameters._const_paths._wasm_specific_only }}
- ${{ parameters._const_paths._wasm_pipelines }}
- ${{ parameters._const_paths._always_exclude }}
- ${{ parameters._const_paths._perf_pipeline_specific_only }}

- eng/Version.Details.xml
- docs/*
Expand Down Expand Up @@ -130,13 +140,15 @@ jobs:
- ${{ parameters._const_paths._wasm_specific_only }}
- ${{ parameters._const_paths._wasm_pipelines }}
- ${{ parameters._const_paths._always_exclude }}
- ${{ parameters._const_paths._perf_pipeline_specific_only }}

- subset: runtimetests
combined: true
include:
- src/tests/*
exclude:
- ${{ parameters._const_paths._wasm_specific_only }}
- ${{ parameters._const_paths._perf_pipeline_specific_only }}

- subset: tools_illink
include:
Expand All @@ -160,6 +172,7 @@ jobs:
- ${{ parameters._const_paths._wasm_specific_only }}
- ${{ parameters._const_paths._wasm_pipelines }}
- ${{ parameters._const_paths._always_exclude }}
- ${{ parameters._const_paths._perf_pipeline_specific_only }}

# We have limited Apple Silicon testing capacity
# We want PR testing on a narrower set of changes
Expand Down Expand Up @@ -219,6 +232,7 @@ jobs:
- ${{ parameters._const_paths._wasm_pipelines }}
exclude:
- ${{ parameters._const_paths._always_exclude }}
- ${{ parameters._const_paths._perf_pipeline_specific_only }}

- subset: wasmdebuggertests
combined: true
Expand All @@ -234,6 +248,7 @@ jobs:
exclude:
- src/mono/nuget/*
- ${{ parameters._const_paths._always_exclude }}
- ${{ parameters._const_paths._perf_pipeline_specific_only }}

# wasm/runtimetests need to be run
- subset: wasm_runtimetests
Expand All @@ -252,6 +267,7 @@ jobs:
- src/mono/wasm/Wasm.Build.Tests/*
- ${{ parameters._const_paths._wasm_pipelines }}
- ${{ parameters._const_paths._always_exclude }}
- ${{ parameters._const_paths._perf_pipeline_specific_only }}

# Wasm except Wasm.build.Tests, and debugger
- subset: wasm_specific_except_wbt_dbg
Expand All @@ -272,6 +288,7 @@ jobs:
- src/mono/nuget/Microsoft.NET.Workload*
- src/mono/nuget/Microsoft.NETCore.BrowserDebugHost.Transport/*
- ${{ parameters._const_paths._always_exclude }}
- ${{ parameters._const_paths._perf_pipeline_specific_only }}

- subset: wasm_chrome
include:
Expand All @@ -284,6 +301,7 @@ jobs:
- ${{ parameters._const_paths._wasm_specific_only }}
- ${{ parameters._const_paths._wasm_pipelines }}
- ${{ parameters._const_paths._always_exclude }}
- ${{ parameters._const_paths._perf_pipeline_specific_only }}
- eng/testing/tests.mobile.targets
- src/mono/*
- src/tasks/AndroidAppBuilder/*
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/coreclr/templates/run-performance-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ parameters:
javascriptEngine: 'NoJS'
helixTypeSuffix: '' # optional -- appends to HelixType
collectHelixLogsScript: '' # optional -- script to collect the logs, and artifacts helpful for debugging failures
additionalSetupParameters: '' # optional -- additional setup parameters that are job-specific
additionalSetupParameters: '' # optional -- additional setup parameters that are job-specific -dummy
radical marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err.. that was a test, I'll remove it!


jobs:
- template: xplat-pipeline-job.yml
Expand Down