Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup iOS scenarios post HybridGlobalization scenario addition #92904

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented Oct 2, 2023

Move iOS Mono and NativeAOT runs to their own build+run file for cleanliness. This deduplicates the iOS build and run code, instead using the HybridGlobalization as a parameter to the template. Also fix the format of the weekly iOS HybridGlobalization build run so all artifacts are built.
 
This should fix the failures seen in the run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2281109&view=results

Test run Mono: https://dev.azure.com/dnceng/internal/_build/results?buildId=2282484&view=results
Test run Native: https://dev.azure.com/dnceng/internal/_build/results?buildId=2282681&view=results

…nliness. Also fix the format of the weekly iOS HybridGlobalization build run so all artifacts are built.
@ghost
Copy link

ghost commented Oct 2, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Move iOS Mono and NativeAOT runs to their own build+run file for cleanliness. This deduplicates the iOS build and run code, instead using the HybridGlobalization as a parameter to the template. Also fix the format of the weekly iOS HybridGlobalization build run so all artifacts are built.
 
This should fix the failures seen in the run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2281109&view=results

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure

Milestone: -

@LoopedBard3 LoopedBard3 marked this pull request as ready for review October 3, 2023 17:15
@LoopedBard3 LoopedBard3 requested a review from radical as a code owner October 3, 2023 17:15
@radical
Copy link
Member

radical commented Oct 3, 2023

WBT failure is a known issue.

@LoopedBard3 LoopedBard3 merged commit 2702df3 into dotnet:main Oct 4, 2023
12 checks passed
@LoopedBard3 LoopedBard3 deleted the PerfFixHGiOSAndMoveiOSToOwnYml branch October 4, 2023 17:41
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants