Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Formats.Cbor package's readme #93021

Conversation

illialarka
Copy link
Contributor

Adding PACKAGE.md for System.Formats.Cbor package.

Progress towards #92228.

Removed since is not applicable
Add list of types which library provides. Listed
public types, means exposed types.
Add library description. Add few code examples
showing basic functionality for CBOR wirter and reader
types.
Since different targets have different dependencies
so I have divided for each section.
Add 'format' word after abbreviation to have an object
in sentence.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 4, 2023
@ghost
Copy link

ghost commented Oct 4, 2023

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Adding PACKAGE.md for System.Formats.Cbor package.

Progress towards #92228.

Author: illialarka
Assignees: -
Labels:

area-System.Security

Milestone: -

Comment on lines 98 to 102
* Provides HashCode types: [Microsoft.Bcl.HashCode](https://www.nuget.org/packages/Microsoft.Bcl.HashCode/)
* Resource pooling: [System.Buffers](https://www.nuget.org/packages/System.Buffers/)
* Efficient memory representation: [System.Memory](https://www.nuget.org/packages/System.Memory/)
* Provides functionality over pointers: [System.Runtime.CompilerServices.Unsafe](https://www.nuget.org/packages/System.Runtime.CompilerServices.Unsafe/)
* Provides underlying type for tuples: [System.ValueTuple](https://www.nuget.org/packages/System.ValueTuple/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What makes these "related"? Based on the fact that it's using TFMs here suggests it's "dependencies", but that's already data that gets surfaced, so why would it be in the description?

I'd, personally, expect this to be more for "this is the primitive layer, but if you want a friendly, opinionated view of a thing that's easier to work with, see [something else]". I don't think there's anything like that with CBOR, so I'd, personally, say there are no "related" packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at this section more like "dependencies" packages for some reason. I am aware that user can see dependencies clicking on "Dependencies" tab.

Overall, you are right! Perhaps, I have misunderstood the purpose of this section. Are you okay if I remove the section completely? I can not list any related packages.

Since there are no related packages.
@illialarka illialarka requested a review from bartonjs October 4, 2023 19:04
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestion

@ViktorHofer ViktorHofer merged commit 37120cd into dotnet:PackageReadmesContinued Oct 9, 2023
13 of 16 checks passed
ViktorHofer pushed a commit that referenced this pull request Oct 20, 2023
* Remove conceptual docummentation item

Removed since is not applicable

* List types library provides

Add list of types which library provides. Listed
public types, means exposed types.

* Add description and usage examples

Add library description. Add few code examples
showing basic functionality for CBOR wirter and reader
types.

* Add related packages section

Since different targets have different dependencies
so I have divided for each section.

* Improve short description

Add 'format' word after abbreviation to have an object
in sentence.

* Remove related packages section

Since there are no related packages.

* Improve array reading/writing example
@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants