Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT] Miscellaneous cleanup #93446

Merged
merged 2 commits into from
Oct 14, 2023
Merged

[NativeAOT] Miscellaneous cleanup #93446

merged 2 commits into from
Oct 14, 2023

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Oct 13, 2023 •
edited
Loading

  • Delete unnecessary abstractions
  • Simplify ifdefs
  • Use more derived types

@ghost ghost assigned jkotas Oct 13, 2023
@ghost
Copy link

ghost commented Oct 13, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Delete unnecessary abstractions
  • Simplify ifdefs
  • Use more derived types types
Author: jkotas
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

@jkotas
Copy link
Member Author

jkotas commented Oct 13, 2023

Peeled off from #93440.

@jkotas
Copy link
Member Author

jkotas commented Oct 13, 2023

@MichalStrehovsky PTLA

@jkotas
[NativeAOT] Miscellaneous cleanup
c115132 
- Delete unnecessary abstractions
- Simplify ifdefs
- Use more derived types
MichalStrehovsky
MichalStrehovsky approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

...iveaot/System.Private.CoreLib/src/Internal/Reflection/Core/NonPortable/RuntimeTypeUnifier.cs Outdated Show resolved Hide resolved
src/libraries/System.Private.CoreLib/src/System/RuntimeType.cs Outdated Show resolved Hide resolved
This was referenced Oct 13, 2023
Open
Closed
Closed
Closed
Closed
Closed
@jkotas @MichalStrehovsky
Apply suggestions from code review
f86f555 
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
@build-analysis build-analysis bot mentioned this pull request Oct 13, 2023
Open
@jkotas jkotas mentioned this pull request Oct 14, 2023
Closed
@jkotas jkotas merged commit 765798c into dotnet:main Oct 14, 2023
171 of 174 checks passed
@jkotas jkotas deleted the misc branch October 14, 2023 05:18
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees

@jkotas jkotas

Labels
area-NativeAOT-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkotas @MichalStrehovsky