[SuperPMI] nativeaot collections build fix #94000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWhen we do SuperPMI collection setup for the 'nativeaot' SmokeTests, it will actually nativeaot compile the tests. We actually do not need to do that as it will be done again when we run the collections. However, we are not able to just 'build' the SmokeTests without having to NativeAOT compile the tests. This PR allows building the nativeaot/SmokeTests without having to specify the
|
This was referenced Oct 26, 2023
TIHan
force-pushed
the
spmi-nativeaot-build-fix
branch
from
b22d8b9 to
da1d4e3
Compare
TIHan
force-pushed
the
spmi-nativeaot-build-fix
branch
from
da1d4e3 to
9bb2496
Compare
|
@jit-contrib @jakobbotsch This is ready. |
jakobbotsch
approved these changes
Oct 27, 2023
liveans
pushed a commit
to liveans/dotnet-runtime
that referenced
this pull request
Nov 9, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #93845
ILLinkneed to be built before building thesmoke_testsbecauseILLinkisn't being restored via a NuGet package anymore, see change: #91468Pipeline results:
https://dev.azure.com/dnceng/internal/_build/results?buildId=2302293&view=results