Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging][wasm] WBT Stop taking latest sdk in release/8.0 #94097

Merged

Conversation

lewing
Copy link
Member

@lewing lewing commented Oct 27, 2023

It looks like wasm build tests have started picking up 8.0.2xx sdks after being unpinned. This pins the WBT sdk to a recent 8.0.1xx sdk which should be new enough for testing and not contain the workload set changes. We could probably set the channel correctly for 1xx and unpin but that can happen later.

We will need to fix wbt for the workload set changes but that definitely doesn't need to happen before 8.0.0.

Fixes #93900

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Oct 27, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: lewing
Assignees: lewing
Labels:

area-System.Reflection.Metadata, new-api-needs-documentation

Milestone: -

@lewing lewing changed the base branch from main to release/8.0 October 27, 2023 17:50
@lewing lewing marked this pull request as ready for review October 27, 2023 19:42
@lewing lewing changed the title [wasm][release/8.0] Test band version theory [release/8.0][wasm] WBT Stop taking latest sdk in release/8.0 Oct 27, 2023
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Oct 27, 2023
@lewing
Copy link
Member Author

lewing commented Oct 27, 2023

@carlossanlop infra only, fixes the wasm failures in release/8.0*

@carlossanlop
Copy link
Member

Is this blocking release/8.0? If yes, then we should merge, but @mmitche needs to confirm.

Otherwise, can you please target 8.0-staging? Because as of right now, the branch is closed.

@lewing
Copy link
Member Author

lewing commented Oct 27, 2023

It is just fixing tests, we can just target staging and ignore the failures if we need to take anything more into release/8.0

@carlossanlop
Copy link
Member

Okay thanks, please retarget: edit the PR title, switch the branch in the dropdown. Note that sometimes git changes the branch in a bad way and ends up bringing in thinks we don't want, so please double check.

@lewing
Copy link
Member Author

lewing commented Oct 27, 2023

I'll retarget once CI finishes then I'd suggest fast merging there

@lewing lewing changed the base branch from release/8.0 to release/8.0-staging October 27, 2023 20:15
@lewing
Copy link
Member Author

lewing commented Oct 27, 2023

This is now all the release/8.0 to release/8.0-staging flow in #93874 I can trim it back to the last three commits if you would prefer.

@lewing
Copy link
Member Author

lewing commented Oct 27, 2023

removed the other commits

@lewing
Copy link
Member Author

lewing commented Oct 27, 2023

fast merging to unblock staging

@carlossanlop carlossanlop merged commit b261d02 into dotnet:release/8.0-staging Oct 27, 2023
9 of 51 checks passed
@lewing lewing changed the title [release/8.0][wasm] WBT Stop taking latest sdk in release/8.0 [release/8.0-staging][wasm] WBT Stop taking latest sdk in release/8.0 Oct 27, 2023
@carlossanlop carlossanlop added this to the 8.0.1 milestone Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Workloads Workloads like wasm-tools Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants