Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch StandaloneApp6x to pre-built test asset #94590

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Switch StandaloneApp6x to pre-built test asset #94590

merged 2 commits into from
Nov 10, 2023

Conversation

elinor-fung
Copy link
Member

  • Switch StandaloneApp6x to be a pre-built test asset
    • Built as a self-contained net6.0 version of existing HelloWorld test asset
  • Update HostVersionCompatibility tests to use the new test asset

@elinor-fung elinor-fung added test-enhancement Improvements of test source code area-Host labels Nov 9, 2023
@ghost
Copy link

ghost commented Nov 9, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Switch StandaloneApp6x to be a pre-built test asset
    • Built as a self-contained net6.0 version of existing HelloWorld test asset
  • Update HostVersionCompatibility tests to use the new test asset
Author: elinor-fung
Assignees: -
Labels:

test-enhancement, area-Host
Milestone: -

@ghost ghost assigned elinor-fung Nov 9, 2023
@build-analysis build-analysis bot mentioned this pull request Nov 10, 2023
Closed
vitek-karas
vitek-karas approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks a lot!

@elinor-fung elinor-fung force-pushed the removeStandaloneApp6x branch from d48106b to e97f789 Compare November 10, 2023 19:50
@build-analysis build-analysis bot mentioned this pull request Nov 10, 2023
Closed
@elinor-fung elinor-fung merged commit d170785 into dotnet:main Nov 10, 2023
175 of 177 checks passed
@elinor-fung elinor-fung deleted the removeStandaloneApp6x branch November 10, 2023 23:24
@akoeplinger akoeplinger mentioned this pull request Nov 22, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitek-karas vitek-karas vitek-karas approved these changes

Assignees

@elinor-fung elinor-fung

Labels
area-Host test-enhancement Improvements of test source code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elinor-fung @vitek-karas