Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Update alpine arm32 in release 8.0 CI #94609

Merged

Conversation

CarnaViire
Copy link
Member

@CarnaViire CarnaViire commented Nov 10, 2023

Contributes to #91757

Alpine docker images were rebuilt on Oct 26, which updated MsQuic to latest -- and brought in a regression for Alpine Arm32.

This PR rolls back to the previous image version that was used before Oct 26. This should stop the noise for release/8.0 that is #91757. For main, I expect we would also update from 3.15 which is EOL to 3.16, so this PR is only for 8.0.

@carlossanlop this is test-infra-only change to reduce noise in CI.

Tested by running the tests in CI, see #94609 (comment)

cc @wfurt @ManickaP @hoyosjs


cc @wfurt - I took a look and alpine arm32 is only used in "checked runtime libraries test" combination. And in that case only 3.15 was used, which is EOL, so I believe we can just bump it to 3.17?

I was thinking and I'm not a fan of reverting to August's docker tag anymore... because it does not contain 10B fix (msquic 2.2.3)

@CarnaViire CarnaViire added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 10, 2023
@ghost ghost assigned CarnaViire Nov 10, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 10, 2023
@CarnaViire
Copy link
Member Author

Ok, the problem is not with 3.15 specifically... logs are full with the same error

System.Net.Quic.Tests.MsQuicCipherSuitesPolicyTests.SupportedCipher_Success [FAIL]
      System.Net.Quic.QuicException : The connection timed out from inactivity.
      Stack Trace:
        /_/src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs(476,0): at System.Net.Quic.QuicConnection.HandleEventShutdownInitiatedByTransport(_SHUTDOWN_INITIATED_BY_TRANSPORT_e__Struct& data)

So it is arm32 + updated msquic 😢 That means pinning the previous image tag seems to be the only fast option @wfurt

@CarnaViire
Copy link
Member Author

Previous tag works, yay 😄😅

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-94609-merge-fd773b474a0e4ee380/System.Net.Quic.Functional.Tests/1/console.5165ff67.log?helixlogtype=result

  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
MsQuic supported and using 'libmsquic.so 2.3.0.0 (b484c06f0867a8a1229219fa9bae352f60eede66)'.
  Discovered:  System.Net.Quic.Functional.Tests (found 124 of 134 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on, max threads = 2)
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 358, Errors: 0, Failed: 0, Skipped: 1, Time: 144.686s
/root/helix/work/workitem/e
----- end Fri Nov 10 19:00:16 UTC 2023 ----- exit code 0 ----------------------------------------------------------

@ghost
Copy link

ghost commented Nov 11, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #91757

Alpine docker images were rebuilt on Oct 26, which updated MsQuic to latest -- and brought in a regression for Alpine Arm32.

This PR rolls back to the previous image version that was used before Oct 26. This should stop the noise for release/8.0 that is #91757. For main, I expect we would also update from 3.15 which is EOL to 3.16, so this PR is only for 8.0.

@carlossanlop this is test-infra-only change to reduce noise in CI.


cc @wfurt - I took a look and alpine arm32 is only used in "checked runtime libraries test" combination. And in that case only 3.15 was used, which is EOL, so I believe we can just bump it to 3.17?

I was thinking and I'm not a fan of reverting to August's docker tag anymore... because it does not contain 10B fix (msquic 2.2.3)

Author: CarnaViire
Assignees: CarnaViire
Labels:

NO-MERGE, area-Infrastructure, needs-area-label

Milestone: -

@CarnaViire CarnaViire removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 11, 2023
@CarnaViire CarnaViire changed the title [NO-MERGE][8.0] Update alpine arm32 in release 8.0 CI [release/8.0-staging] Update alpine arm32 in release 8.0 CI Nov 11, 2023
@CarnaViire CarnaViire removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 11, 2023
@CarnaViire CarnaViire marked this pull request as ready for review November 11, 2023 00:45
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok if this is a temp fix, but it's better to keep containers patched. Is there any plan to re-enable the moving tag?

@wfurt wfurt added the Servicing-approved Approved for servicing release label Nov 11, 2023
@wfurt
Copy link
Member

wfurt commented Nov 11, 2023

test only change to stabilize CI @carlossanlop

@wfurt
Copy link
Member

wfurt commented Nov 11, 2023

I'm ok if this is a temp fix, but it's better to keep containers patched. Is there any plan to re-enable the moving tag?

This issue appears to be a regression in MsQuic. We should look into it and open a tracking issue in their repository. It's not something within our direct purview to address.

@wfurt wfurt merged commit d0804a9 into dotnet:release/8.0-staging Nov 11, 2023
101 of 108 checks passed
@carlossanlop carlossanlop added this to the 8.0.1 milestone Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants