Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] [mono] catch the case of updated methods in mono_debug_lookup_source_location #94612

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 10, 2023

Backport of #94540 to release/8.0-staging

/cc @lambdageek

Related to #93860

Customer Impact

Customers using C# hot reload on mobile platforms or WebAssembly may add new methods that throw exceptions without crashing the runtime.

Testing

New CI tests; manual testing.

Risk

Low

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc label Nov 10, 2023
@lambdageek lambdageek added this to the 8.0.x milestone Nov 10, 2023
@lambdageek lambdageek added the Servicing-consider Issue for next servicing release review label Nov 10, 2023
@github-actions github-actions bot force-pushed the backport/pr-94540-to-release/8.0-staging branch from 862589c to 1d89ea4 Compare November 12, 2023 20:48
@github-actions github-actions bot requested a review from radical as a code owner November 12, 2023 20:48
@lambdageek lambdageek self-assigned this Nov 13, 2023
@lambdageek lambdageek added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 13, 2023
@lambdageek
Copy link
Member

Approved by tactics via email

@lambdageek lambdageek merged commit 0087f0b into release/8.0-staging Nov 13, 2023
144 checks passed
@akoeplinger akoeplinger deleted the backport/pr-94540-to-release/8.0-staging branch November 14, 2023 13:53
@carlossanlop carlossanlop modified the milestones: 8.0.x, 8.0.1 Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants