-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the hashtable for EEClassHash #94825
Merged
Merged
Commits on Nov 16, 2023
-
Fixup EEClassHash to support a hash function that includes enclosing …
…class - Move namespace/name splitting to the Type.GetType code paths - Move exported type handling into the normal PopulateAvailableClass flow - Remove unnecessary work done to detect typedef name duplicates. We don't attempt to protect against invaild assemblies anymore - Unify path for insertion between ExportedType and TypeDef records, also unify the path for nested vs non-nested - Fix logic which implements inserts into the case insensitive table when dynamically adding entries to the ExportedType table (Previously it didn't work) - Update the ECMA 335 augments to capture the requirement that nested ExportedTypes must have a higher RID than the enclosing ExportedType - This requirement has actually always existed since .NET 1.0, but was never recorded
Configuration menu - View commit details
-
Copy full SHA for 7e94553 - Browse repository at this point
Copy the full SHA 7e94553View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1790ea - Browse repository at this point
Copy the full SHA e1790eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b1b6f6 - Browse repository at this point
Copy the full SHA 5b1b6f6View commit details -
Remove use of FindTypeDef from its only common use pattern. This api …
…is a linear scan of the entire typedef table, and we already have the right hash to make this cheap
Configuration menu - View commit details
-
Copy full SHA for f08041b - Browse repository at this point
Copy the full SHA f08041bView commit details -
Remove extra hash field we really didn't need on EEClassHashEntry
- Also make the code more DAC correct (probably not completely correct, but this logic does not appear to actually be used within the DAC)
Configuration menu - View commit details
-
Copy full SHA for a97426e - Browse repository at this point
Copy the full SHA a97426eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff60cb9 - Browse repository at this point
Copy the full SHA ff60cb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93723fc - Browse repository at this point
Copy the full SHA 93723fcView commit details
Commits on Nov 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 14af763 - Browse repository at this point
Copy the full SHA 14af763View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81228fe - Browse repository at this point
Copy the full SHA 81228feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64e1282 - Browse repository at this point
Copy the full SHA 64e1282View commit details
Commits on Nov 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6ceb5d0 - Browse repository at this point
Copy the full SHA 6ceb5d0View commit details
Commits on Nov 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 551c8e9 - Browse repository at this point
Copy the full SHA 551c8e9View commit details
Commits on Dec 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 67af66d - Browse repository at this point
Copy the full SHA 67af66dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dc1e0a - Browse repository at this point
Copy the full SHA 3dc1e0aView commit details
Commits on Jan 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a41aa8c - Browse repository at this point
Copy the full SHA a41aa8cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.