[wasm] Allow scalar valuetypes with r4/r8 members. #94969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
requested review from
BrzVlad,
kotlarmilos,
fanyang-mono,
lambdageek and
SamMonoRT
as code owners
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
assigned 
|
Re: #94895 |
kg
reviewed
Nov 19, 2023
| /* Scalar vtypes are passed by value */ | ||
| if (mini_wasm_is_scalar_vtype (sig->params [i])) | ||
| // FIXME: r4/r8 | ||
| if (mini_wasm_is_scalar_vtype (sig->params [i], &etype) && etype->type != MONO_TYPE_R4 && etype->type != MONO_TYPE_R8) { | ||
| margs->iargs [int_i] = *(gpointer*)margs->iargs [int_i]; |
There was a problem hiding this comment.
Will this work correctly for i8/u8? I'm fine with not fixing those yet though
There was a problem hiding this comment.
We disable those:
} else if (size == 8 && t->type != MONO_TYPE_R8) {
return FALSE;
|
LGTM |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Nov 19, 2023
|
The Build browser-wasm linux Release LibraryTests_AOT failures are relevant. |
vargaz
force-pushed
the
wasm-scalar-vtype
branch
from
8911be7 to
93438f8
Compare
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
teo-tsirpanis
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
|
Failures are unrelated. |
lewing
approved these changes
Nov 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.