Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasi] CI: Add AOT library tests job #95146

Merged
merged 14 commits into from
Nov 28, 2023
Merged

[wasi] CI: Add AOT library tests job #95146

merged 14 commits into from
Nov 28, 2023

Conversation

radical
Copy link
Member

@radical radical commented Nov 22, 2023

  • misc fixes
  • [wasi] Add support for building AOT library tests on helix
  • [wasi] CI: Add AOT smoke tests
  • Share targets for running AOT tests
  • cleanup

This adds the job to runtime-wasm also, which will run a larger subset of tests but will ignore any failures. For the smoke tests job, failures are not ignored.

@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Nov 22, 2023
@ghost
Copy link

ghost commented Nov 22, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • misc fixes
  • [wasi] Add support for building AOT library tests on helix
  • [wasi] CI: Add AOT smoke tests
  • cleanup
Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@radical
Copy link
Member Author

radical commented Nov 23, 2023

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Nov 23, 2023

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Nov 23, 2023

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical requested a review from ilonatommy November 27, 2023 18:58
@radical
Copy link
Member Author

radical commented Nov 27, 2023

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Nov 27, 2023

Failures are unrelated.

@radical
Copy link
Member Author

radical commented Nov 28, 2023

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue for the unflagged debugger timeout before merging

@@ -3,7 +3,7 @@
<!-- FIXME: update the condition for this in Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets -->
<_RuntimeIdentifierUsesAppHost>false</_RuntimeIdentifierUsesAppHost>
<TargetArchitecture>wasm</TargetArchitecture>
<TargetOS>Browser</TargetOS>
<TargetOS>wasi</TargetOS>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah... this is where that was coming from.

@radical
Copy link
Member Author

radical commented Nov 28, 2023

Please open an issue for the unflagged debugger timeout before merging

Build Analysis is still showing the timeout but the tests were re-run automatically, and didn't fail. I have opened #95343 anyway.

@radical radical merged commit 7c31be1 into dotnet:main Nov 28, 2023
197 of 204 checks passed
@radical radical deleted the wasi-aot branch November 28, 2023 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants