Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid parameters in SetFileInformationByHandle #95235

Merged
merged 2 commits into from
Nov 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -464,10 +464,10 @@ public static unsafe void SetAttributes(SafeFileHandle fileHandle, FileAttribute
private static void SetFileTime(
string fullPath,
bool asDirectory,
long creationTime = -1,
long lastAccessTime = -1,
long lastWriteTime = -1,
long changeTime = -1,
long creationTime = 0,
long lastAccessTime = 0,
long lastWriteTime = 0,
long changeTime = 0,
uint fileAttributes = 0)
{
using SafeFileHandle handle = OpenHandleToWriteAttributes(fullPath, asDirectory);
Expand All @@ -477,10 +477,10 @@ private static void SetFileTime(
private static unsafe void SetFileTime(
SafeFileHandle fileHandle,
string? fullPath = null,
long creationTime = -1,
long lastAccessTime = -1,
long lastWriteTime = -1,
long changeTime = -1,
long creationTime = 0,
long lastAccessTime = 0,
long lastWriteTime = 0,
long changeTime = 0,
uint fileAttributes = 0)
{
var basicInfo = new Interop.Kernel32.FILE_BASIC_INFO
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Threading.Tasks;
using Microsoft.Win32.SafeHandles;
using Xunit;

Expand Down Expand Up @@ -91,15 +92,34 @@ protected override DateTime GetLastWriteTimeUtc(string path)
return File.GetLastWriteTimeUtc(fileHandle);
}

[Fact]
public async Task WritingShouldUpdateWriteTime_After_SetLastAccessTime()
{
string filePath = GetTestFilePath();
using var handle = OpenFileHandle(filePath, FileAccess.ReadWrite);

File.SetLastAccessTime(handle, DateTime.Now.Subtract(TimeSpan.FromDays(1)));
var timeBeforeWrite = File.GetLastWriteTime(handle);

using var writer = new StreamWriter(new FileStream(handle, FileAccess.ReadWrite));
writer.AutoFlush = true;
writer.WriteLine("now: " + DateTime.Now);
await Task.Delay(2000);
writer.WriteLine("now: " + DateTime.Now);

var timeAfterWrite = File.GetLastWriteTime(handle);
Assert.True(timeAfterWrite > timeBeforeWrite);
}

[Fact]
public void NullArgumentValidation()
{
Assert.Throws<ArgumentNullException>("fileHandle", static () => File.GetCreationTime(default(SafeFileHandle)!));
Assert.Throws<ArgumentNullException>("fileHandle", static () => File.SetCreationTime(default(SafeFileHandle)!, DateTime.Now));

Assert.Throws<ArgumentNullException>("fileHandle", static () => File.GetCreationTimeUtc(default(SafeFileHandle)!));
Assert.Throws<ArgumentNullException>("fileHandle", static () => File.SetCreationTimeUtc(default(SafeFileHandle)!, DateTime.Now));

Assert.Throws<ArgumentNullException>("fileHandle", static () => File.GetLastAccessTime(default(SafeFileHandle)!));
Assert.Throws<ArgumentNullException>("fileHandle", static () => File.SetLastAccessTime(default(SafeFileHandle)!, DateTime.Now));

Expand Down
Loading