Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/roslyn #95301

Merged
merged 48 commits into from
Dec 6, 2023
Merged

[main] Update dependencies from dotnet/roslyn #95301

merged 48 commits into from
Dec 6, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 27, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 037eb78c-9902-4cb9-856d-08db8ed7cafd
  • Build: 20231205.11
  • Date Produced: December 6, 2023 5:56:19 AM UTC
  • Commit: 92a930f3247040ec9c077dac9bcdf0294745b339
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
26ad12b 
…127.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-2.23577.2
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Nov 27, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
052a397 
…127.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-2.23577.3
@build-analysis build-analysis bot mentioned this pull request Nov 28, 2023
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
03bc056 
…127.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-2.23577.4
This was referenced Nov 28, 2023
Open
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
b2c11c7 
…127.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-2.23577.6
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
573bd81 
…127.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-2.23577.7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
d75eff1 
…127.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23577.8
@build-analysis build-analysis bot mentioned this pull request Nov 28, 2023
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
61ba225 
…128.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23578.1
@build-analysis build-analysis bot mentioned this pull request Nov 28, 2023
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
c748455 
…128.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23578.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
2676642 
…128.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23578.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
27decf6 
…128.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23578.8
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
3c5f912 
…128.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23578.9
This was referenced Nov 29, 2023
Closed
Closed
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
9ca58be 
…129.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
f3fe66c 
…129.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
de96ccc 
…129.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
101f69d 
…129.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
c3343d7 
…129.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.6
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
3af7235 
…129.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
f8eacc6 
…129.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.8
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
32d4aaa 
…129.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.9
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
c8c72b6 
…129.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.10
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
f3eb057 
…129.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23579.11
dotnet-maestro bot and others added 9 commits December 1, 2023 13:12
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
96ed608 
…201.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23601.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
b22deba 
…201.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23601.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
0badffc 
…201.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23601.6
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
9450753 
…201.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23601.7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
d940159 
…201.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23601.8
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
1e1182f 
…201.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23601.9
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
6599d88 
…202.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23602.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
35f41ee 
…204.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23604.1
@lewing
work around new analsis warning
bb378d6
@lewing
Copy link
Member

lewing commented Dec 4, 2023

it looks like the new analyzer error is just assigning to a local that is not used again. I'm not really sure why it is a local in the first place though so it's possible this should be cleaned up more.

cc @stephentoub

@stephentoub
Copy link
Member

it looks like the new analyzer error is just assigning to a local that is not used again. I'm not really sure why it is a local in the first place though so it's possible this should be cleaned up more.

cc @stephentoub

Which analyzer? There's one about dead stores; I assume it's that one. Sounds like the code can just be cleaned up.

@lewing
Copy link
Member

lewing commented Dec 4, 2023

src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLDecimal.cs(1280,17): error IDE0059: (NETCORE_ENGINEERING_TELEMETRY=Build) Unnecessary assignment of a value to 'fMySignPos' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0059)

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
6884ec0 
…204.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23604.3
@build-analysis build-analysis bot mentioned this pull request Dec 4, 2023
Open
dotnet-maestro bot and others added 8 commits December 5, 2023 01:07
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
0b47257 
…204.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23604.7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
5857ab0 
…204.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23604.9
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
5b7bc6f 
…204.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23604.10
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
bb3578f 
…204.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23604.11
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
7e53702 
…205.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23605.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
cfc7eca 
…205.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23605.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
c875817 
…205.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23605.3
@akoeplinger
Fix analyzer issues
ae80c1a
@akoeplinger
Copy link
Member

Out of curiosity I checked the internal TFS sources and the oldest copy I can find from late 2007 has exactly the same code with the fMySignPos being unnecessarily assigned so at least it's not some recent change :)

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
457137f 
…205.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23605.9
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn build 20231…
d107d6d 
…205.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23605.11
@akoeplinger
Copy link
Member

@dotnet-policy-service rerun

@akoeplinger akoeplinger merged commit 4d8dfff into main Dec 6, 2023
191 checks passed
@akoeplinger akoeplinger deleted the darc-main-5f154009-9026-4ea5-8a74-0bdba385ea98 branch December 6, 2023 09:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewing @stephentoub @akoeplinger