Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make WritingShouldUpdateWriteTime_After_SetLastAccessTime more resilient #95336

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

adamsitnik
Copy link
Member

Hopefully fixes #95298

@adamsitnik adamsitnik added area-System.IO test-enhancement Improvements of test source code labels Nov 28, 2023
@adamsitnik adamsitnik added this to the 9.0.0 milestone Nov 28, 2023
@adamsitnik adamsitnik self-assigned this Nov 28, 2023
@ghost
Copy link

ghost commented Nov 28, 2023

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Hopefully fixes #95298

Author: adamsitnik
Assignees: adamsitnik
Labels:

area-System.IO, test-enhancement

Milestone: 9.0.0

@adamsitnik
Copy link
Member Author

/azp list

Copy link

CI/CD Pipelines for this repository:

@adamsitnik
Copy link
Member Author

/azp run Build Libraries Test Run release coreclr windows x86 Release

Copy link

No pipelines are associated with this pull request.

@adamsitnik
Copy link
Member Author

@dotnet/area-infrastructure-libraries I've recently merged a test that fails only on x86. I would like to ensure that my fix helps (I was not able to repro locally for hours) and run "Build Libraries Test Run release coreclr windows x86 Release" few times. How can I do that? It's green for this PR, so there is no re-run option in the GUI. Thanks!

@ViktorHofer
Copy link
Member

@dotnet/area-infrastructure-libraries I've recently merged a test that fails only on x86. I would like to ensure that my fix helps (I was not able to repro locally for hours) and run "Build Libraries Test Run release coreclr windows x86 Release" few times. How can I do that? It's green for this PR, so there is no re-run option in the GUI. Thanks!

AFAIK you can't rerun certain legs in AzDO unless they fail. You could manually submit to Helix but I'm not an expert on that. I think state of the art is to close and then re-open the PR so that everything is retriggered.

@jozkee jozkee merged commit 6d8dbc7 into dotnet:main Nov 28, 2023
109 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.IO test-enhancement Improvements of test source code
Projects
None yet
4 participants