-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][mt] dynamic thread create #95702
Merged
pavelsavara
merged 2 commits into
dotnet:main
from
pavelsavara:browser_mt_dynamic_thread_create
Dec 13, 2023
Merged
[browser][mt] dynamic thread create #95702
pavelsavara
merged 2 commits into
dotnet:main
from
pavelsavara:browser_mt_dynamic_thread_create
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
WebAssembly architecture
area-VM-threading-mono
os-browser
Browser variant of arch-wasm
labels
Dec 6, 2023
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Dec 7, 2023
pavelsavara
force-pushed
the
browser_mt_dynamic_thread_create
branch
2 times, most recently
from
December 8, 2023 15:55
665337b
to
2f852a6
Compare
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
force-pushed
the
browser_mt_dynamic_thread_create
branch
from
December 12, 2023 11:58
2f852a6
to
edf8e14
Compare
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
requested review from
lewing,
thaystg,
radical and
kg
as code owners
December 12, 2023 12:21
31 tasks
lewing
approved these changes
Dec 12, 2023
radical
reviewed
Dec 13, 2023
...time.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSWebWorker.cs
Show resolved
Hide resolved
...time.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSWebWorker.cs
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
40
to5
, but floating, not just at the start<_WasmPThreadPoolSize>
from project filesPTHREAD_POOL_SIZE_STRICT=0
which will not throw when we run out of thread pool threads, but it will allocate more.getNewWorker
internal and use it to trigger adding more to the emscripten's thread pool.PThread
internalWebWorker
toJSWebWorker
JSWebWorker
await JavaScriptImports.ThreadAvailable
toJSWebWorker
so that we are sure that the pthread is ready/loadedJSWebWorker
from the pool, because they have dirty JS state