Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Bump chrome for testing - linux: 120.0.6099.71, windows: 120.0.6099.71 #95832

Merged
merged 2 commits into from
Dec 13, 2023
+10 −10
Merged

[wasm] Bump chrome for testing - linux: 120.0.6099.71, windows: 120.0.6099.71 #95832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6965f3b
Automated bump of chrome version
github-actions[bot] Dec 10, 2023
715c990
[wasm] Disable DebuggerTests.CallFunctionOnTests.CheckVSCodeTestFunct…
radical Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions eng/testing/ChromeVersions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<Project>
<PropertyGroup>
<linux_ChromeVersion>119.0.6045.159</linux_ChromeVersion>
<linux_ChromeRevision>1204232</linux_ChromeRevision>
<linux_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1204234</linux_ChromeBaseSnapshotUrl>
<linux_V8Version>11.9.169</linux_V8Version>
<linux_ChromeVersion>120.0.6099.71</linux_ChromeVersion>
<linux_ChromeRevision>1217362</linux_ChromeRevision>
<linux_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1217362</linux_ChromeBaseSnapshotUrl>
<linux_V8Version>12.0.267</linux_V8Version>

<win_ChromeVersion>119.0.6045.160</win_ChromeVersion>
<win_ChromeRevision>1204232</win_ChromeRevision>
<win_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1204234</win_ChromeBaseSnapshotUrl>
<win_V8Version>11.9.169</win_V8Version>
<win_ChromeVersion>120.0.6099.71</win_ChromeVersion>
<win_ChromeRevision>1217362</win_ChromeRevision>
<win_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1217378</win_ChromeBaseSnapshotUrl>
<win_V8Version>12.0.267</win_V8Version>
</PropertyGroup>
</Project>
4 changes: 2 additions & 2 deletions src/mono/wasm/debugger/DebuggerTestSuite/CallFunctionOnTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ public CallFunctionOnTests(ITestOutputHelper testOutput) : base(testOutput)
// This tests `callFunctionOn` with a function that the vscode-js-debug extension uses
// Using this here as a non-trivial test case
[ConditionalTheory(nameof(RunningOnChrome))]
[InlineData("big_array_js_test (10);", "/other.js", 10, 1, 10, false)]
[InlineData("big_array_js_test (0);", "/other.js", 10, 1, 0, true)]
// [InlineData("big_array_js_test (10);", "/other.js", 10, 1, 10, false)] - ActiveIssue https://github.com/dotnet/runtime/issues/95950
// [InlineData("big_array_js_test (0);", "/other.js", 10, 1, 0, true)] - ActiveIssue https://github.com/dotnet/runtime/issues/95950
[InlineData("invoke_static_method ('[debugger-test] DebuggerTests.CallFunctionOnTest:LocalsTest', 10);", "dotnet://debugger-test.dll/debugger-cfo-test.cs", 23, 12, 10, false)]
[InlineData("invoke_static_method ('[debugger-test] DebuggerTests.CallFunctionOnTest:LocalsTest', 0);", "dotnet://debugger-test.dll/debugger-cfo-test.cs", 23, 12, 0, true)]
public async Task CheckVSCodeTestFunction1(string eval_fn, string bp_loc, int line, int col, int len, bool roundtrip)
Expand Down
Loading