Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm64: Change regMaskTP to struct #96196

Closed
wants to merge 7 commits into from
Closed

Arm64: Change regMaskTP to struct #96196

wants to merge 7 commits into from

Conversation

kunalspathak
Copy link
Member

This is an experiment to see the TP impact. This is the 2nd experiment when we found out that #94589 won't work.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 19, 2023
@ghost ghost assigned kunalspathak Dec 19, 2023
@ghost
Copy link

ghost commented Dec 19, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This is an experiment to see the TP impact. This is the 2nd experiment when we found out that #94589 won't work.

Author: kunalspathak
Assignees: kunalspathak
Labels:

area-CodeGen-coreclr
Milestone: -

@kunalspathak
Copy link
Member Author

Diffs

image image

I will next try to add high field in the new struct and consume it at all the places necessary to see its TP impact.

@kunalspathak kunalspathak changed the title Change regMaskTP to struct with 1 field Arm64: Change regMaskTP to struct Dec 20, 2023
@kunalspathak kunalspathak added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Dec 20, 2023
@build-analysis build-analysis bot mentioned this pull request Dec 20, 2023
Closed
@kunalspathak
Copy link
Member Author

kunalspathak commented Dec 20, 2023 •
edited
Loading

I will next try to add high field in the new struct and consume it at all the places necessary to see its TP impact.

Alright, now we are talking about numbers :)

Diffs

image

image

So yes, the worst performance with having struct is 10%. I will start working on segregating regMaskTP as mentioned in #94589 (comment).

cc: @BruceForstall

@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kunalspathak