Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UInt64.CreateSaturating<Int128> truncates instead of saturates #96369

Merged
merged 3 commits into from
Jan 16, 2024
Merged

UInt64.CreateSaturating<Int128> truncates instead of saturates #96369

merged 3 commits into from
Jan 16, 2024

Conversation

pedrobsaila
Copy link
Contributor

Fixes #94523

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 30, 2023
@ghost
Copy link

ghost commented Dec 30, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #94523

Author: pedrobsaila
Assignees: -
Labels:

area-System.Runtime
Milestone: -

This was referenced Jan 3, 2024
Open
Closed
Closed
Closed
@tannergooding
Copy link
Member

Failures are likely unrelated and look to be an issue that was resolved yesterday. Rerunning so we can get this merged

@tannergooding tannergooding merged commit 3c4b628 into dotnet:main Jan 16, 2024
178 checks passed
@tannergooding
Copy link
Member

/backport to release/8.0-staging

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7547488726

@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Merged
@pedrobsaila pedrobsaila deleted the 94523 branch January 16, 2024 21:31
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@pedrobsaila @stephentoub
@tannergooding @tmds
UInt64.CreateSaturating<Int128> truncates instead of saturates (dotne…
6160277 
…t#96369)

* UInt64.CreateSaturating<Int128> truncates instead of saturates

* Update src/libraries/System.Private.CoreLib/src/System/Int128.cs

---------

Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@tannergooding tannergooding tannergooding approved these changes

Assignees
No one assigned
Labels
area-System.Runtime community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UInt64.CreateSaturating<Int128> truncates instead of saturates
3 participants
@pedrobsaila @tannergooding @stephentoub