-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Mac symbols in .dSYM bundle, not single .dwarf file #96456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resurrecting #94237 |
ghost
assigned BruceForstall
Jan 3, 2024
Tagging subscribers to this area: @hoyosjs Issue Detailsnull
|
BruceForstall
force-pushed
the
BuildMacSymbolsInDSym
branch
from
January 26, 2024 00:04
a017b43
to
e7cc1bc
Compare
This was referenced Jan 26, 2024
BruceForstall
force-pushed
the
BuildMacSymbolsInDSym
branch
from
February 16, 2024 00:32
e7cc1bc
to
b4471be
Compare
Treat .dSYM bundle as set of files. There are places where this doesn't work very well, such as in src/installer/pkg/projects/Directory.Build.targets, where the `GetSymbolPackageFiles` target is trying to construct a set of debug files to package, while also giving them a TargetPath property. I haven't been able to figure out how to get MSBuild to do my bidding in creating the right paths.
BruceForstall
force-pushed
the
BuildMacSymbolsInDSym
branch
from
February 28, 2024 00:20
2b78673
to
3608689
Compare
This was referenced Feb 28, 2024
Work to address #92911 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.